Rewrite exists(property) to property IS NOT NULL. No AUTO cherry-pick #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the former syntax is deprecated and scheduled for removal in Neo4j.
The syntax was a mix of old and new constraint syntax and this not valid
Hunterness
requested changes
Mar 15, 2022
| @@ -551,7 +554,7 @@ public void testIndexesMoreLabels() { | |||
| @Test | |||
| public void testSchemaRelationshipsExclude() { | |||
| ignoreException(() -> { | |||
| db.executeTransactionally("CREATE CONSTRAINT FOR ()-[like:LIKED]-() REQUIRE exists(like.day)"); | |||
| db.executeTransactionally("CREATE CONSTRAINT FOR ()-[like:LIKED]-() REQUIRE like.day I"); | |||
There was a problem hiding this comment.
I feel like some part is missing here?
Hunterness
approved these changes
Mar 15, 2022
Lojjs
changed the title
Hunterness
requested changes
Mar 15, 2022
| | name | type | properties | status | ||
| | "CONSTRAINT ON ()-[liked:LIKED]-() ASSERT exists(liked.day)" | "RELATIONSHIP_PROPERTY_EXISTENCE" | ["day"] | "" | ||
| | name | type | properties | status | ||
| | "CONSTRAINT ON ()-[liked:LIKED]-() ASSERT liked.day IS NOT NULL" | "RELATIONSHIP_PROPERTY_EXISTENCE" | ["day"] | "" |
There was a problem hiding this comment.
Actually this should be updated to use FOR .. REQUIRE as well
There was a problem hiding this comment.
Yes. I get over 100 matches on CONSTRAINT ON on apoc dev though so I think we need a separate PR for that though if you don't have one open already?
AzuObs
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update APOC syntax to adapt to removal of exists(property) in Neo4j.