Fixes #2607: apoc.export.json.data JSON format missing brace #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
added
the
core-functionality
Lojjs
reviewed
Apr 20, 2022
Comment on lines
-54
to
53
| } finally { | ||
| writer.close(); | ||
| } |
There was a problem hiding this comment.
Is it safe to remove the write.close()? Keeping it but still moving the two reporter lines will also solve the issue.
There was a problem hiding this comment.
The writer.close() should be unnecessary, because the WriterBasedJsonGenerator.close(), called by the getJsonGenerator(writer), has a writer.close();, so we can remove it because of try-with-resource.
There was a problem hiding this comment.
Ah ok, sounds like it should be fine then :) Just wanted to check so it wasn't unintentional
Lojjs
requested changes
Apr 20, 2022
Lojjs
approved these changes
Apr 20, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Apr 20, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Apr 20, 2022
Lojjs
pushed a commit
that referenced
this pull request
Apr 20, 2022
…2772) NO AUTO Co-authored-by: Giuseppe Villani <[email protected]>
Lojjs
pushed a commit
that referenced
this pull request
Apr 20, 2022
…2773) Co-authored-by: Giuseppe Villani <[email protected]>
Lojjs
pushed a commit
that referenced
this pull request
Apr 20, 2022
Lojjs
added a commit
that referenced
this pull request
Apr 20, 2022
Lojjs
added a commit
that referenced
this pull request
Apr 20, 2022
Lojjs
added a commit
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2607
reporter.done()andreporter.getTotal()have to be executed afterjsonGenerator.close()