Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exports tests #2746

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Exports tests #2746

merged 1 commit into from
Apr 21, 2022

Conversation

AzuObs
Copy link
Contributor

@AzuObs AzuObs commented Apr 12, 2022 •
edited
Loading

Fix ExportFeatureTests

Proposed Changes

  • Providing constraint names explicitly so that we can check the export contains those explicit names
  • In the CI, stop comparing the response's CypherStatement against our expectations: apoc.export.all populates a file and does not return a CypherStatement

@Lojjs Lojjs self-assigned this Apr 19, 2022
@AzuObs
Fix ExportFeaturesTest
b5b66a0 
These tests were broken because:
- an anonymous constraint name was generated that didn't match the existing test assertion
- in the CI we would check the cypher response object for row results when in reality this apoc procedure populates a file instead
Lojjs
Lojjs approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AzuObs AzuObs merged commit 43039e3 into dev Apr 21, 2022
@AzuObs AzuObs deleted the exports-tests branch April 21, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzuObs @Lojjs