Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting namespace to be internal instead of unsupported #2771

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ public class ExportStreamsStatementsTest {

@ClassRule
static public DbmsRule db = new ImpermanentDbmsRule()
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false);
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false);

@BeforeClass
public static void setUp() throws Exception {
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/apoc/export/cypher/ExportCypherTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public class ExportCypherTest {
@Rule
public DbmsRule db = new ImpermanentDbmsRule()
.withSetting(GraphDatabaseSettings.load_csv_file_url_root, directory.toPath().toAbsolutePath())
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false);
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false);

@Rule
public TestName testName = new TestName();
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/apoc/graph/GraphsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ public class GraphsTest {

@Rule
public DbmsRule db = new ImpermanentDbmsRule()
.withSetting(SettingImpl.newBuilder("unsupported.dbms.debug.track_cursor_close", SettingValueParsers.BOOL, false).build(), false)
.withSetting(SettingImpl.newBuilder("unsupported.dbms.debug.trace_cursors", SettingValueParsers.BOOL, false).build(), false);
.withSetting(SettingImpl.newBuilder("internal.dbms.debug.track_cursor_close", SettingValueParsers.BOOL, false).build(), false)
.withSetting(SettingImpl.newBuilder("internal.dbms.debug.trace_cursors", SettingValueParsers.BOOL, false).build(), false);

@Before
public void setUp() throws Exception {
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/apoc/load/LoadJsonTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ private void commonAssertionsLoadJsonMulti(Result result) {
(r) -> {}
)
);
assertTrue(e.getMessage().contains("access to /127.168.0.0 is blocked via the configuration property unsupported.dbms.cypher_ip_blocklist"));
assertTrue(e.getMessage().contains("access to /127.168.0.0 is blocked via the configuration property internal.dbms.cypher_ip_blocklist"));
}
}
@Test public void testLoadMultiJsonPaths() throws Exception {
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/apoc/meta/MetaTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ public class MetaTest {
@Rule
public DbmsRule db = new ImpermanentDbmsRule()
.withSetting(GraphDatabaseSettings.procedure_unrestricted, singletonList("apoc.*"))
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false);
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false);

@Before
public void setUp() throws Exception {
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/apoc/path/LabelSequenceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ public class LabelSequenceTest {

@ClassRule
public static DbmsRule db = new ImpermanentDbmsRule()
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false);
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false);

@BeforeClass
public static void setUp() throws Exception {
Expand Down
4 changes: 2 additions & 2 deletions core/src/test/java/apoc/refactor/GraphRefactoringTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ public class GraphRefactoringTest {

@Rule
public DbmsRule db = new ImpermanentDbmsRule()
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false);
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false);

@Before
public void setUp() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ class NLPHelperFunctionsWithDatabaseTest {
@ClassRule
@JvmField
val neo4j = ImpermanentDbmsRule()
.withSetting(SettingImpl.newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(SettingImpl.newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false)
.withSetting(SettingImpl.newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(SettingImpl.newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false)
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class AWSVirtualEntitiesGraphStoreTest {
@ClassRule
@JvmField
val neo4j = ImpermanentDbmsRule()
.withSetting(newBuilder( "unsupported.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "unsupported.dbms.debug.trace_cursors", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.track_cursor_close", BOOL, false ).build(), false)
.withSetting(newBuilder( "internal.dbms.debug.trace_cursors", BOOL, false ).build(), false)

}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ class GCPVirtualEntitiesGraphStoreTest {
@ClassRule
@JvmField
val neo4j = ImpermanentDbmsRule()
.withSetting(SettingImpl.newBuilder("unsupported.dbms.debug.track_cursor_close", SettingValueParsers.BOOL, false).build(), false)
.withSetting(SettingImpl.newBuilder("unsupported.dbms.debug.trace_cursors", SettingValueParsers.BOOL, false).build(), false)
.withSetting(SettingImpl.newBuilder("internal.dbms.debug.track_cursor_close", SettingValueParsers.BOOL, false).build(), false)
.withSetting(SettingImpl.newBuilder("internal.dbms.debug.trace_cursors", SettingValueParsers.BOOL, false).build(), false)
}

@Test
Expand Down