Added apoc.date.convert() and apoc.date.add() #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InverseFalcon
changed the title
jexp
reviewed
Feb 24, 2017
src/main/java/apoc/date/Date.java
Outdated
| @@ -136,6 +136,19 @@ public String systemTimezone() { | |||
| return TimeZone.getDefault().getID(); | |||
| } | |||
|
|
|||
| @UserFunction | |||
| @Description("apoc.date.convert(12345,'ms|s|m|h|d','ms|s|m|h|d') convert a time unit into a different time unit") | |||
| public Long convert(@Name("time") long time, @Name(value = "unit") String unit, @Name(value = "toUnit") String toUnit) { | |||
There was a problem hiding this comment.
are there any sensible default values?
There was a problem hiding this comment.
Maybe 'ms' for the unit value, but I'm wondering if in this case a default value would be easier to work with or make usage more error-prone.
|
looks good to me, can you add them to docs/overview.adoc too? |
jexp
approved these changes
Feb 24, 2017
src/main/java/apoc/date/Date.java
Outdated
| @@ -136,6 +136,19 @@ public String systemTimezone() { | |||
| return TimeZone.getDefault().getID(); | |||
| } | |||
|
|
|||
| @UserFunction | |||
| @Description("apoc.date.convert(12345,'ms|s|m|h|d','ms|s|m|h|d') convert a time unit into a different time unit") | |||
| public Long convert(@Name("time") long time, @Name(value = "unit") String unit, @Name(value = "toUnit") String toUnit) { | |||
InverseFalcon
force-pushed
the
DateAdditions
branch
from
c3f6b59
to
a7385ea
Compare
InverseFalcon
added a commit
to InverseFalcon/neo4j-apoc-procedures
that referenced
this pull request
Mar 13, 2017
* Added apoc.date.convert() and apoc.date.add() and unit tests * Added documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fulfills the feature request in #289.