5.0 fix security review issues #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
added
5.0
team-cypher-surface
gem-neo4j
force-pushed
the
5.0_fix_security_review_issues
branch
from
e89863b
to
92944d3
Compare
ncordon
reviewed
Jun 15, 2022
ncordon
reviewed
Jun 15, 2022
ncordon
reviewed
Jun 15, 2022
ncordon
approved these changes
Jun 16, 2022
gem-neo4j
added a commit
to gem-neo4j/neo4j-apoc-procedures
that referenced
this pull request
Jun 16, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() i * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
gem-neo4j
added a commit
that referenced
this pull request
Jun 16, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
gem-neo4j
added a commit
to gem-neo4j/neo4j-apoc-procedures
that referenced
this pull request
Jun 16, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
gem-neo4j
added a commit
that referenced
this pull request
Jun 16, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
vga91
pushed a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Jun 29, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
gem-neo4j
added a commit
to gem-neo4j/neo4j-apoc-procedures
that referenced
this pull request
Jul 12, 2022
* Remove use of new FileInputStream by replacing it with Files.newInputStream() i * Add Spotless as a gradle plugin to enforce the removal of unused imports * Handle empty catch block; throw runtime exception to give information back to the user * Remove printing Stack Traces in non test functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the security code review I have: