Fixes #2932: The apoc.import.csv skipLines config doesn't work correctly #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t work correctly
Lojjs
approved these changes
Jun 21, 2022
Comment on lines
195
to
198
| // skip header and another one | ||
| testSkipLine(1L, 2); | ||
|
|
||
| // skip only-header (default config) |
There was a problem hiding this comment.
I assume these two comments should switch place?
There was a problem hiding this comment.
@vga91 Thanks for fixing, looks good now!
neo4j-oss-build
pushed a commit
that referenced
this pull request
Jun 24, 2022
neo4j-oss-build
pushed a commit
that referenced
this pull request
Jun 24, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Jun 24, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Jun 24, 2022
vga91
added a commit
to vga91/neo4j-apoc-procedures
that referenced
this pull request
Jun 29, 2022
vga91
added a commit
that referenced
this pull request
Jul 5, 2022
…tly (#2984) (#3012) Co-authored-by: Giuseppe Villani <[email protected]>
vga91
added a commit
that referenced
this pull request
Jul 5, 2022
…tly (#2984) (#3011) Co-authored-by: Giuseppe Villani <[email protected]>
gem-neo4j
pushed a commit
to gem-neo4j/neo4j-apoc-procedures
that referenced
this pull request
Jul 12, 2022
…t work correctly (neo4j-contrib#2984) (neo4j-contrib#3012) Co-authored-by: Giuseppe Villani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2932
Leverage on
CsvReaderto skipLines,because
CountingReader.skip(n)callsjava.io.FilterReader.skip(n), which skip characters instead of lines.removing the
CountingReader.skipis not a breaking-change because by default isskip(0), so theCountingReaderskip nothing actually.changed deprecated API
CSVReadertoCSVReaderBuilder