NO AUTO Renames core to common package, makes core and full depend on it #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
force-pushed
the
dev-split-core-full
branch
from
431f030
to
9117335
Compare
ncordon
force-pushed
the
dev-split-core-full
branch
from
9117335
to
18d0afb
Compare
ncordon
commented
Jul 29, 2022
ncordon
commented
Jul 29, 2022
ncordon
commented
Jul 29, 2022
ncordon
commented
Jul 29, 2022
ncordon
commented
Jul 29, 2022
ncordon
force-pushed
the
dev-split-core-full
branch
from
566ab31
to
401cecd
Compare
ncordon
force-pushed
the
dev-split-core-full
branch
from
0628b55
to
07d2189
Compare
AzuObs
reviewed
Aug 1, 2022
common/build.gradle
Outdated
| minHeapSize = '128m' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you think we could remove this completely in the 3 common/core/processor build.gradle files?
I'm not sure the tests are particularly parallelizable unfortunately, even when run locally.
There was a problem hiding this comment.
I've removed it, so let's see, but I'm not a fan of introducing unnecessary changes in PRs and this was pre-existing and if it makes the CI fail I will undo.
ncordon
changed the title
They are running, but they contain only docker tests which are ignored (unfortunately at the moment) |
ncordon
force-pushed
the
dev-split-core-full
branch
from
4f0f9b9
to
37e0ce0
Compare
ncordon
force-pushed
the
dev-split-core-full
branch
from
37e0ce0
to
acb1adb
Compare
AzuObs
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Renames core to common, creates a new core package and makes core and full depend on common.
Why
This is a step towards splitting core and full completely. Next step should move procedures from common to core, increasingly.
Next
core? At the moment it's left incommoncore->testdepends oncommon->test. Should we remove that in the future?full.