Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOID] Removes load json test, the data is not in the external API anymore #3302

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

ncordon
Copy link
Contributor

@ncordon ncordon commented Nov 18, 2022

Cherry-picks neo4j/apoc#243

Why

The json disappeared from the external service. There's still another test that loads a json from stackexchange, so that should be enough to test the functionality.

These files should be moved to the repo probably and accessed through a github url rather than depending on external services.

@ncordon ncordon added cherry-picked This PR has been cherry-picked to the other active branches 4.4 labels Nov 18, 2022
@ncordon ncordon merged commit 360e4e3 into 4.4 Nov 18, 2022
@ncordon ncordon deleted the 4.4-removes-test-no-data branch November 18, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 cherry-picked This PR has been cherry-picked to the other active branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant