[TOQo1n9M] apoc-hadoop dependency is conflicting #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vga91
force-pushed
the
hadoop-dependency-conflict
branch
from
3340137
to
680a8e2
Compare
Lojjs
approved these changes
Feb 16, 2023
Comment on lines
+33
to
+34
| return Paths.get( basePath.concat(project) ) | ||
| .toFile(); |
There was a problem hiding this comment.
Comparing with the old code, there was a slash in the concat method: .concat("/full") now this will be .concat(full). Does that matter?
There was a problem hiding this comment.
Yeah, I forgot to mention it.
How it was before wasn't totally right,
because basePath is for example /My/Path/neo4j-apoc-procedures/.
By doing basePath.concat("/full") becomes /My/Path/neo4j-apoc-procedures//full (with a double slash before full).
Then Paths.get(...) removes the double slash indeed,
but I guess it's better to remove it beforehand.
There was a problem hiding this comment.
Ok that makes sense, thanks for explaining
vga91
added a commit
that referenced
this pull request
Feb 16, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Mar 13, 2023
vga91
added a commit
that referenced
this pull request
Mar 13, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Mar 14, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Mar 14, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Apr 3, 2023
…4j-contrib/neo4j-apoc-procedures#3450) (#347) * [TOQo1n9M] Core part - apoc-hadoop dependency is conflicting 5.x (neo4j-contrib/neo4j-apoc-procedures#3450) * [TOQo1n9M] changed getProjectPath() to isExtendedProject()
vga91
added a commit
that referenced
this pull request
Apr 3, 2023
vga91
added a commit
to neo4j/apoc
that referenced
this pull request
Apr 12, 2023
…4j-contrib/neo4j-apoc-procedures#3450) (#347) * [TOQo1n9M] Core part - apoc-hadoop dependency is conflicting 5.x (neo4j-contrib/neo4j-apoc-procedures#3450) * [TOQo1n9M] changed getProjectPath() to isExtendedProject()
vga91
added a commit
that referenced
this pull request
Apr 13, 2023
vga91
added a commit
that referenced
this pull request
Apr 18, 2023
vga91
added a commit
that referenced
this pull request
Apr 21, 2023
vga91
added a commit
that referenced
this pull request
Apr 21, 2023
vga91
added a commit
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addExtraDependencies()in TestContainerUtil