Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #302 - procedure to rename property, rename label, rename reltype #371

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

DanielBerton
Copy link

Indexes and constraints are managed, legacy indexes are not

});
}
if (prop != null) {
Iterable<ConstraintDefinition> constraintsForProps = db.schema().getConstraints();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indexes too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

});
});
}
List<BatchAndTotalResult>targetLongList = iterate.collect(Collectors.toList());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterate.findFirst().orElse(null);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better

@jexp
Copy link
Member

jexp commented Apr 5, 2017

Looks good to me.

@jexp
Copy link
Member

jexp commented Apr 5, 2017

can you fix the two small things?

@inserpio
Copy link
Member

inserpio commented Apr 5, 2017

@jexp ok to postpone manual and automatic indexes management?

@jexp
Copy link
Member

jexp commented Apr 6, 2017

@inserpio sure, we can even leave it to the user or make it an option

@jexp jexp merged commit 784745e into neo4j-contrib:3.1 Apr 7, 2017
jexp pushed a commit that referenced this pull request Apr 12, 2017
albertodelazzari pushed a commit to albertodelazzari/neo4j-apoc-procedures that referenced this pull request Jun 28, 2017
ncordon pushed a commit to ncordon/neo4j-apoc-procedures that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants