Adding support for java.sql.Date in JDBC to convert to String #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
requested changes
Apr 25, 2017
| @Test | ||
| public void testLoadJdbcSelect() throws Exception { | ||
| testCall(db, "CALL apoc.load.jdbc('jdbc:derby:derbyDB','SELECT * FROM PERSON')", | ||
| (row) -> assertEquals(singletonMap("NAME", "John"), row.get("row"))); | ||
| (row) -> assertEquals(new HashMap<String,Object>(){{ |
There was a problem hiding this comment.
please use Util.map() in all these places.
src/main/java/apoc/load/Jdbc.java
Outdated
| @@ -140,6 +141,12 @@ private Object convert(Object value) { | |||
| if (value instanceof UUID || value instanceof BigInteger || value instanceof BigDecimal) { | |||
| return value.toString(); | |||
| } | |||
| if (value instanceof java.sql.Date) { | |||
There was a problem hiding this comment.
don't need this as they all inherit from java.util.Date
jexp
approved these changes
Apr 25, 2017
albertodelazzari
pushed a commit
to albertodelazzari/neo4j-apoc-procedures
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.