Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4087: Add vector info procedures #4142

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fixes #4087: Add vector info procedures #4142

merged 3 commits into from
Jul 31, 2024

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Jul 11, 2024

Fixes #4087

  • Added methodAndPayloadNull method as a workaround, since we cannot explicit "method: GET" as setChunkedStreamingMode makes procedures throw a HTTP 405 Method Not Allowed,
    and by forcing payload == null we make sure that the procedure does not go here, and in this way it still has as default method "GET", which is the required method for all of them except the milvus one
  • Added apoc.vectordb.<vectorDbName>.info(hostOrKey, collection, $config) procedures

Other changes

Refactoring: added some comments in extended/src/main/java/apoc/vectordb/VectorDbUtil.java

@@ -7,6 +7,7 @@ note that the list and the signature procedures are consistent with the others,
[opts=header, cols="1, 3"]
|===
| name | description
| apoc.vectordb.chroma.info(hostOrKey, collection, $config) | Get information about specified existing collection

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add information about the output when the collection does not exists (return null? throws error?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, i.e. throws an error if it does not exist

----
CALL apoc.vectordb.pinecone.info(hostOrKey, 'test-collection', {<optional config>})
----

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added below

@RobertoSannino RobertoSannino merged commit 97b4fff into dev Jul 31, 2024
5 checks passed
@RobertoSannino RobertoSannino deleted the issue-4087 branch July 31, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants