fixes #391 - Update documentation for procedures that have converted to functions #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
reviewed
May 3, 2017
docs/datetime.adoc
Outdated
| @@ -6,11 +6,8 @@ endif::env-guide[] | |||
|
|
|||
| == Conversion between formatted dates and timestamps | |||
|
|
|||
| * `apoc.date.parseDefault('2015-03-25 03:15:59','s')` get Unix time equivalent of given date (in seconds) | |||
| * `apoc.date.parse('2015/03/25 03-15-59','s','yyyy/MM/dd HH/mm/ss')` same as previous, but accepts custom datetime format | |||
There was a problem hiding this comment.
mark that here everything beyon the first parameter is optional .e.g with ['s']
jexp
reviewed
May 3, 2017
| * `apoc.number.parseInt.pattern(text, pattern) yield value` parse a text using a pattern and the default system language to produce a long | ||
| * `apoc.number.parseInt.lang(text, lang) yield value` parse a text using the default system pattern and a language to produce a long | ||
| * `apoc.number.parseInt.pattern.lang(text, pattern, lang) yield value` parse a text using a pattern and a language to produce a long | ||
| * `apoc.number.parseInt(text)` parse a text using the default system pattern and language to produce a long |
There was a problem hiding this comment.
these should have a short example like this, and a full with the optional parameters marked
jexp
reviewed
May 3, 2017
docs/number.adoc
Outdated
| * `apoc.number.parseFloat.pattern.lang(text, pattern, lang) yield value` parse a text using a pattern and a language to produce a double | ||
|
|
||
| * The full list of supported values for `pattern` and `lang` params is described in https://docs.oracle.com/javase/9/docs/api/java/text/DecimalFormat.html[DecimalFormat JavaDoc] | ||
| * `apoc.number.parseFloat(text)` parse a text using the default system pattern and language to produce a double |
There was a problem hiding this comment.
these should have a short example like this, and a full with the optional parameters marked
jexp
reviewed
May 3, 2017
| @@ -33,63 +21,13 @@ | |||
| .... | |||
|
|
|||
| .... | |||
| call apoc.number.format.pattern.lang(12345, '#,##0.00;(#,##0.00)', 'it') yield value | |||
There was a problem hiding this comment.
don't remove them but replace them with the proper RETURN apoc.number.format(.. with full parameters
jexp
reviewed
May 3, 2017
docs/spatial.adoc
Outdated
| @@ -169,25 +169,3 @@ ORDER BY distance | |||
| LIMIT 100 | |||
| ---- | |||
|
|
|||
| == Combined Space and Time search | |||
There was a problem hiding this comment.
where is the replacement for this? where the procedure calls are replaced with a function call?
|
Ping @AngeloBusato |
…ve converted to functions
|
@jexp Done, PR updated |
albertodelazzari
pushed a commit
to albertodelazzari/neo4j-apoc-procedures
that referenced
this pull request
Jun 28, 2017
…ve converted to functions (neo4j-contrib#427)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't found some procedures/functions, so we deleted them from documentation.
apoc.number.format.lang
apoc.number.format.pattern
apoc.number.format.pattern.lang
apoc.number.parseInt.pattern
apoc.number.parseInt.lang
apoc.number.parseInt.pattern.lang
apoc.number.parseFloat.pattern
apoc.number.parseFloat.lang
apoc.number.parseFloat.pattern.lang
apoc.date.formatDefault
apoc.date.parseDefault
apoc.date.formatTimeZone
apoc.date.fieldsFormatted
apoc.date.fieldsDefault