Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx termination tests #574

Merged
merged 13 commits into from
Jul 4, 2023

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Jun 28, 2023

These tests verify transaction and its results handling when the transaction is terminated by a failure.

@injectives injectives force-pushed the feature/txtermination branch 2 times, most recently from b00eda3 to 05b3698 Compare June 28, 2023 10:52
@injectives injectives force-pushed the feature/txtermination branch 4 times, most recently from 6d5fa90 to 4c4a158 Compare July 3, 2023 15:42
@injectives injectives changed the title Add tx termination test based on failed tx.run Add tx termination tests Jul 3, 2023
@injectives injectives force-pushed the feature/txtermination branch 2 times, most recently from f2546f0 to 27632c1 Compare July 3, 2023 16:04
These tests verify transaction and its results handling when the transaction is terminated by a failure.
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎬

Some small comments, but no blockers among them.

tests/stub/tx_run/scripts/tx_error_on_pull.script Outdated Show resolved Hide resolved
tests/stub/tx_run/test_tx_run.py Show resolved Hide resolved
tests/stub/tx_run/test_tx_run.py Outdated Show resolved Hide resolved
tests/stub/tx_run/test_tx_run.py Outdated Show resolved Hide resolved
tests/stub/tx_run/test_tx_run.py Show resolved Hide resolved
tests/stub/tx_run/test_tx_run.py Show resolved Hide resolved
@injectives injectives merged commit eec5f2a into neo4j-drivers:5.0 Jul 4, 2023
@injectives injectives deleted the feature/txtermination branch July 4, 2023 10:52
robsdedude added a commit that referenced this pull request Jul 5, 2023
Adjustment for Go for new tests and assertions added in
#574
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jul 5, 2023
bigmontz added a commit to neo4j/neo4j-javascript-driver that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants