Order by rework #39
Open
Order by rework #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make sure tests are passing for PHP 7.4, 8.0 and 8.1. |
|
Looks like I did a whoopsie. I fixed it, so there aren't any regressions on the Query object |
wgevaert
requested changes
Apr 25, 2022
wgevaert
approved these changes
May 5, 2022
|
Please make sure the checks are passing. |
|
I have been looking at this, and I cannot seem to find any documentation on this. I tried it out, and it did seem to work. Is this documented anywhere? |
marijnvanwezel
force-pushed
the
main
branch
from
419d00f
to
259564d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello once again 👋
I just found out ORDER BY allows for order modifier for each property. This is possible:
ORDER BY x.x ASC, x.y DESCFor this reason I had to rework the OrderByClause to use Order objects and not worry about the order itself.
Looking forward to your feedback!