-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4Bmcyc2U] Fix ignored S3 tests #241
Conversation
68181a0
to
5f4d638
Compare
01e71f9
to
7f85b46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f9020d2
to
67084e2
Compare
I changed the S3PerformanceTest (now it takes about 1 min) with a smaller dataset created via some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes a lot of sense to use the movies dataset, and 1 minute is fine for now.
Thanks a lot for the hard work. Approved 🎉
67084e2
to
8f75d31
Compare
* [4Bmcyc2U] Fix ignored S3 tests * fix tests * lightened ExportS3PerformanceTest
* [4Bmcyc2U] Fix ignored S3 tests * fix tests * lightened ExportS3PerformanceTest
* [4Bmcyc2U] Fix ignored S3 tests * fix tests * lightened ExportS3PerformanceTest
* [4Bmcyc2U] Fix ignored S3 tests * fix tests * lightened ExportS3PerformanceTest
* [4Bmcyc2U] Fix ignored S3 tests * fix tests * lightened ExportS3PerformanceTest
Fix ignored S3 tests.
Now we use a
localstack
container, as done in extended, inLoadS3Test
.S3Container
from apoc-extended (used inLoadS3Test
) totest-utils
. See related pr.S3BaseTest
testImplementation group: 'com.amazonaws'
fromcommon/build.gradle
S3Container
changes:S3Container
Instead of move the uploaded files from a S3 location to a temp directory and then compare the files with
TestUtil.readFileToString
, now the comparison is executed without moving the file directly withIOUtils.toString(s3File)
Other changes:
GraphMLUtils.java
FileUtils.assertStreamEquals
(common toExportJsonTest
andExportJsonS3Test
)