Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum versions - Neo4j 5.s and Node.js 20.x #5638

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Bump minimum versions - Neo4j 5.s and Node.js 20.x #5638

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
718a761
Bump minimums of Neo4j and Node.js
darrellwarde Oct 8, 2024
576d488
Remove GHA tests against 4.4
darrellwarde Oct 8, 2024
7a32656
Update all engines
darrellwarde Oct 8, 2024
a1abaef
Update blue-sloths-enjoy.md
darrellwarde Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/blue-sloths-enjoy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@neo4j/graphql": major
"@neo4j/graphql-ogm": major
---

The Neo4j GraphQL Library now requires a Neo4j 5.x database.
6 changes: 6 additions & 0 deletions .changeset/wild-knives-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@neo4j/graphql": major
"@neo4j/graphql-ogm": major
darrellwarde marked this conversation as resolved.
Show resolved Hide resolved
---

The Neo4j GraphQL Library now requires Node.js 20 or greater.
2 changes: 0 additions & 2 deletions .github/workflows/reusable-api-library-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ jobs:
- "^15.0.0"
- "^16.0.0"
neo4j-version:
- 4.4-community
- 4.4-enterprise
- 5-community
- 5-enterprise

Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/reusable-integration-tests-on-prem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ jobs:
{ package: "graphql", shard: 4/4, coverage_name: 6 },
]
neo4j-version:
# - 4.4-community
- 4.4-enterprise
# - 5-community
- 5-enterprise
graphql-version: [
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/reusable-subscriptions-plugin-amqp-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ jobs:
- "^15.0.0"
- "^16.0.0"
neo4j-version:
# - 4.4-community
- 4.4-enterprise
# - 5-community
- 5-enterprise
services:
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dist/**/*.js.map"
],
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
darrellwarde marked this conversation as resolved.
Show resolved Hide resolved
},
"scripts": {
"build": "tsc --build src/tsconfig.production.json",
Expand Down
14 changes: 7 additions & 7 deletions packages/graphql/src/classes/utils/verify-database.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
*/

import type { Driver, Session } from "neo4j-driver";
import checkNeo4jCompat from "./verify-database";
import { REQUIRED_APOC_FUNCTIONS, MIN_NEO4J_VERSION } from "../../constants";
import { Neo4jDatabaseInfo } from "../Neo4jDatabaseInfo";
import { MIN_NEO4J_VERSION, REQUIRED_APOC_FUNCTIONS } from "../../constants";
import type { Neo4jGraphQLSessionConfig } from "../Executor";
import { Neo4jDatabaseInfo } from "../Neo4jDatabaseInfo";
import checkNeo4jCompat from "./verify-database";

describe("checkNeo4jCompat", () => {
test("should add driver config to session", async () => {
Expand Down Expand Up @@ -270,15 +270,15 @@ describe("checkNeo4jCompat", () => {
).resolves.not.toThrow();
});

test("should not throw Error that 4.2 is minimum", async () => {
test("should throw Error for Neo4j 4.4", async () => {
// @ts-ignore
const fakeSession: Session = {
// @ts-ignore
run: () => ({
records: [
{
toObject: () => ({
version: "4.1.10",
version: "4.4.37",
functions: REQUIRED_APOC_FUNCTIONS,
}),
},
Expand All @@ -296,8 +296,8 @@ describe("checkNeo4jCompat", () => {
verifyConnectivity: () => undefined,
};

await expect(checkNeo4jCompat({ driver: fakeDriver, dbInfo: new Neo4jDatabaseInfo("4.1.10") })).rejects.toThrow(
`Encountered the following DBMS compatiblility issues:\nExpected minimum Neo4j version: '${MIN_NEO4J_VERSION}', received: '4.1.10'`
await expect(checkNeo4jCompat({ driver: fakeDriver, dbInfo: new Neo4jDatabaseInfo("4.4.37") })).rejects.toThrow(
`Encountered the following DBMS compatiblility issues:\nExpected minimum Neo4j version: '${MIN_NEO4J_VERSION}', received: '4.4.37'`
);
});
});
2 changes: 1 addition & 1 deletion packages/graphql/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const DEBUG_PREFIX = "@neo4j/graphql";

export const AUTH_FORBIDDEN_ERROR = "@neo4j/graphql/FORBIDDEN";
export const AUTH_UNAUTHENTICATED_ERROR = "@neo4j/graphql/UNAUTHENTICATED";
export const MIN_NEO4J_VERSION = "4.4";
export const MIN_NEO4J_VERSION = "5.0";
export const REQUIRED_APOC_FUNCTIONS = ["apoc.util.validatePredicate", "apoc.date.convertFormat"];
export const AUTHORIZATION_UNAUTHENTICATED = "Unauthenticated";
export const DEBUG_ALL = `${DEBUG_PREFIX}:*`;
Expand Down
2 changes: 1 addition & 1 deletion packages/introspector/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dist/**/*.js.map"
],
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"scripts": {
"build:clean": "yarn clean && yarn build",
Expand Down
2 changes: 1 addition & 1 deletion packages/ogm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dist/**/*.js.map"
],
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"scripts": {
"build": "tsc --build tsconfig.production.json",
Expand Down
Loading