Change unexported return type to interfaces

Fixes #378
neo4j · Jul 8, 2022 · d3fa5a0 · d3fa5a0
1 parent a3779e6
commit d3fa5a0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/neo4j/result.go b/neo4j/result.go
@@ -57,7 +57,7 @@ type result struct {
 }
 
 // deprecated: use newResultWithContext instead
-func newResult(conn db.Connection, str db.StreamHandle, cypher string, params map[string]interface{}) *result {
+func newResult(conn db.Connection, str db.StreamHandle, cypher string, params map[string]interface{}) Result {
 	return newResultWithContext(conn, str, cypher, params).legacy()
 }
 

diff --git a/neo4j/result_with_context.go b/neo4j/result_with_context.go
@@ -53,7 +53,8 @@ type ResultWithContext interface {
 	Consume(ctx context.Context) (ResultSummary, error)
 	// IsOpen determines whether this result cursor is available
 	IsOpen() bool
-	legacy() *result
+	buffer(ctx context.Context)
+	legacy() Result
 }
 
 const consumedResultError = "result cursor is not available anymore"
@@ -72,7 +73,7 @@ type resultWithContext struct {
 }
 
 func newResultWithContext(conn idb.Connection, str idb.StreamHandle,
-	cypher string, params map[string]interface{}) *resultWithContext {
+	cypher string, params map[string]interface{}) ResultWithContext {
 	return &resultWithContext{
 		conn:         conn,
 		streamHandle: str,
@@ -199,7 +200,7 @@ func (r *resultWithContext) IsOpen() bool {
 	return r.isOpen()
 }
 
-func (r *resultWithContext) legacy() *result {
+func (r *resultWithContext) legacy() Result {
 	return &result{delegate: r}
 }
 

diff --git a/neo4j/transaction_with_context.go b/neo4j/transaction_with_context.go
@@ -160,7 +160,7 @@ func (tx *managedTransaction) legacy() Transaction {
 // Does not implement the ExplicitTransaction nor the ManagedTransaction interface.
 type autocommitTransaction struct {
 	conn     db.Connection
-	res      *resultWithContext
+	res      ResultWithContext
 	closed   bool
 	onClosed func()
 }