Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerberos auth requires principal for backwards compatibility #264

Merged
merged 7 commits into from
Oct 4, 2021

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Sep 16, 2021

neo4j-drivers/testkit#237 expands the definition of the AuthToken (code).

Waiting for said PR to be merged.

TestKit backend:
 - Make realm an optional field in TestKit authToken
 - Add feature flags to get these changes tests
@robsdedude robsdedude changed the title Make realm an optional field in TestKit authToken Kerberos auth requires principal for backwards compatibility Sep 16, 2021
@robsdedude robsdedude marked this pull request as draft September 16, 2021 17:01
testkit-backend/backend.go Outdated Show resolved Hide resolved
Deprecate `auth_tokens.keyTicket`, should be "credentials".
@robsdedude robsdedude force-pushed the optional-realm-in-testkit-auth-token branch from bed2db0 to 0e482e5 Compare September 28, 2021 12:13
@robsdedude robsdedude marked this pull request as ready for review October 1, 2021 13:21
@robsdedude robsdedude force-pushed the optional-realm-in-testkit-auth-token branch 2 times, most recently from 50f59a9 to 1fd2a56 Compare October 4, 2021 08:15
@robsdedude robsdedude force-pushed the optional-realm-in-testkit-auth-token branch from 1fd2a56 to 2472ee3 Compare October 4, 2021 08:16
neo4j/auth_tokens_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fbiville fbiville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a tiny change needed

@fbiville fbiville merged commit 7af530e into neo4j:4.4 Oct 4, 2021
@robsdedude robsdedude deleted the optional-realm-in-testkit-auth-token branch October 5, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants