-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerberos auth requires principal for backwards compatibility #264
Merged
fbiville
merged 7 commits into
neo4j:4.4
from
robsdedude:optional-realm-in-testkit-auth-token
Oct 4, 2021
Merged
Kerberos auth requires principal for backwards compatibility #264
fbiville
merged 7 commits into
neo4j:4.4
from
robsdedude:optional-realm-in-testkit-auth-token
Oct 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestKit backend: - Make realm an optional field in TestKit authToken - Add feature flags to get these changes tests
robsdedude
changed the title
Make realm an optional field in TestKit authToken
Kerberos auth requires principal for backwards compatibility
Sep 16, 2021
fbiville
approved these changes
Sep 16, 2021
Deprecate `auth_tokens.keyTicket`, should be "credentials".
robsdedude
force-pushed
the
optional-realm-in-testkit-auth-token
branch
from
September 28, 2021 12:13
bed2db0
to
0e482e5
Compare
robsdedude
force-pushed
the
optional-realm-in-testkit-auth-token
branch
2 times, most recently
from
October 4, 2021 08:15
50f59a9
to
1fd2a56
Compare
robsdedude
force-pushed
the
optional-realm-in-testkit-auth-token
branch
from
October 4, 2021 08:16
1fd2a56
to
2472ee3
Compare
fbiville
reviewed
Oct 4, 2021
fbiville
reviewed
Oct 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a tiny change needed
fbiville
reviewed
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neo4j-drivers/testkit#237 expands the definition of the AuthToken (code).
Waiting for said PR to be merged.