Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auth tests in TestKit backend #773

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

robsdedude
Copy link
Member

@robsdedude robsdedude commented Sep 16, 2021

Kerberos auth should use the ticket field instead of the credentials field
to transmit the auth token.

Furthermore, extend the TestKit backend to utilize the different auth helper
functions and enable feature flags to test them.

Waiting for neo4j-drivers/testkit#237 to be merged.

Kerberos auth should use the `ticket` field instead of the `credentials` field
to transmit the auth token.

Furthermore, extend the TestKit backend to utilize the different auth helper
functions and enable feature flags to test them.
@robsdedude robsdedude marked this pull request as ready for review September 16, 2021 17:03
@robsdedude
Copy link
Member Author

Turns out this change is not needed, and that credentials is actually the correct field to have the kerberos token in. Still, this PR has value in that it enables the according TestKit tests.

@robsdedude robsdedude changed the title Fix Kerberos auth to use ticket Enable auth tests in TestKit backend Oct 4, 2021
@bigmontz bigmontz merged commit 698595d into neo4j:4.4 Oct 5, 2021
@robsdedude robsdedude deleted the fix-kerberos-auth branch October 6, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants