Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Decimal/int for sub-second precision in datetime values; fixes #525 #551

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Use Decimal/int for sub-second precision in datetime values; fixes #525 #551

merged 3 commits into from
Sep 21, 2021

Conversation

robsdedude
Copy link
Member

No description provided.

robsdedude
robsdedude commented Jun 15, 2021
View reviewed changes
Copy link
Member Author

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: continue review from here.

neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
robsdedude
robsdedude commented Jun 16, 2021
View reviewed changes
neo4j/time/__init__.py Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/__init__.py Outdated Show resolved Hide resolved
neo4j/time/hydration.py Outdated Show resolved Hide resolved
tests/unit/time/test_datetime.py Show resolved Hide resolved
@robsdedude robsdedude force-pushed the fix-datetime-precission-decimal branch from 79d435d to 85d78df Compare September 20, 2021 04:34
@robsdedude robsdedude changed the base branch from 4.3 to 4.4 September 20, 2021 04:35
@robsdedude robsdedude force-pushed the fix-datetime-precission-decimal branch from 85d78df to 363bf84 Compare September 20, 2021 14:12
@robsdedude robsdedude merged commit 4b34926 into neo4j:4.4 Sep 21, 2021
@robsdedude robsdedude deleted the fix-datetime-precission-decimal branch September 21, 2021 09:08
robsdedude added a commit to robsdedude/neo4j-python-driver that referenced this pull request Jan 4, 2022
@robsdedude
Apply 5.0 deprecation and renaming to neo4j.time module.
7301c9d 
This makes the module more robust as it models sub-second precision with ints
instead of floats. This finishes off the work started in PR neo4j#551.

Breaking changes:
 - `Duration`
   - The constructor does not accept `subseconds` anymore.
     Use `milliseconds`, `microseconds`, or `nanoseconds` instead.
   - The property `subseconds` has been removed.
     Use `nanoseconds` instead.
   - The property `hours_minutes_seconds` has been removed.
     Use `hours_minutes_seconds_nanoseconds` instead.
   - For all math operations holds: they are element-wise on
     (`months`, `days`, `nanoseconds`).
     This affects (i.e., changes) the working of `//`, `%`, `/`, and `*`.
     - Years are equal to 12 months.
     - Weeks are equal to 7 days.
     - `seconds`, `milliseconds`, `microseconds`, and `nanoseconds` are
       implicitly converted to `nanoseconds` or `seconds` as fit.
   - Multiplication and division allow for floats but will always result in
     integer values (round to nearest even).
 - `Time`
   - The constructor does not accept `float`s for `second` anymore.
     Use `nanosecond` instead.
   - Ticks are now nanoseconds since midnight (`int`).
     - The property `ticks_ns` has been renamed to `ticks`.
       The old `ticks` is no longer supported.
     - The property`from_ticks_ns` has been renamed to `from_ticks`.
       The old `from_ticks` is no longer supported.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
 - `DateTime`
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
@robsdedude robsdedude mentioned this pull request Jan 4, 2022
Merged
robsdedude added a commit to robsdedude/neo4j-python-driver that referenced this pull request Jan 4, 2022
@robsdedude
Apply 5.0 deprecation and renaming to neo4j.time module.
53022c7 
This makes the module more robust as it models sub-second precision with ints
instead of floats. This finishes off the work started in PR neo4j#551.

Breaking changes:
 - `Duration`
   - The constructor does not accept `subseconds` anymore.
     Use `milliseconds`, `microseconds`, or `nanoseconds` instead.
   - The property `subseconds` has been removed.
     Use `nanoseconds` instead.
   - The property `hours_minutes_seconds` has been removed.
     Use `hours_minutes_seconds_nanoseconds` instead.
   - For all math operations holds: they are element-wise on
     (`months`, `days`, `nanoseconds`).
     This affects (i.e., changes) the working of `//`, `%`, `/`, and `*`.
     - Years are equal to 12 months.
     - Weeks are equal to 7 days.
     - `seconds`, `milliseconds`, `microseconds`, and `nanoseconds` are
       implicitly converted to `nanoseconds` or `seconds` as fit.
   - Multiplication and division allow for floats but will always result in
     integer values (round to nearest even).
 - `Time`
   - The constructor does not accept `float`s for `second` anymore.
     Use `nanosecond` instead.
   - Ticks are now nanoseconds since midnight (`int`).
     - The property `ticks_ns` has been renamed to `ticks`.
       The old `ticks` is no longer supported.
     - The property`from_ticks_ns` has been renamed to `from_ticks`.
       The old `from_ticks` is no longer supported.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
 - `DateTime`
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
robsdedude added a commit that referenced this pull request Jan 13, 2022
@robsdedude
Apply 5.0 deprecation and renaming to neo4j.time module. (#635)
97fd0e1 
This makes the module more robust as it models sub-second precision with ints
instead of floats. This finishes off the work started in PR #551.

Breaking changes:
 - `Duration`
   - The constructor does not accept `subseconds` anymore.
     Use `milliseconds`, `microseconds`, or `nanoseconds` instead.
   - The property `subseconds` has been removed.
     Use `nanoseconds` instead.
   - The property `hours_minutes_seconds` has been removed.
     Use `hours_minutes_seconds_nanoseconds` instead.
   - For all math operations holds: they are element-wise on
     (`months`, `days`, `nanoseconds`).
     This affects (i.e., changes) the working of `//`, `%`, `/`, and `*`.
     - Years are equal to 12 months.
     - Weeks are equal to 7 days.
     - `seconds`, `milliseconds`, `microseconds`, and `nanoseconds` are
       implicitly converted to `nanoseconds` or `seconds` as fit.
   - Multiplication and division allow for floats but will always result in
     integer values (round to nearest even).
 - `Time`
   - The constructor does not accept `float`s for `second` anymore.
     Use `nanosecond` instead.
   - Ticks are now nanoseconds since midnight (`int`).
     - The property `ticks_ns` has been renamed to `ticks`.
       The old `ticks` is no longer supported.
     - The property`from_ticks_ns` has been renamed to `from_ticks`.
       The old `from_ticks` is no longer supported.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
 - `DateTime`
   - The property `hour_minute_second` has been removed.
     Use `hour_minute_second_nanosecond` instead.
   - The property `second` returns an `int` instead of a `float`.
     Use `nanosecond` to get the sub-second information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robsdedude