Fast failing discovery on certain errors. #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver tries its best to fetch a routing table. It will try all possible routers while skipping routers on most errors. However, there are a few errors that are caused by the client. Those errors should be surfaced to the user for a better UX/DX and should fail fast: there is no reason to try another router if we expect it tho return the same error. Those errors are: - `Neo.ClientError.Database.DatabaseNotFound` - all `Neo.ClientError.Security.*` - except `Neo.ClientError.Security.AuthorizationExpired` - `Neo.ClientError.Transaction.InvalidBookmark` - `Neo.ClientError.Transaction.InvalidBookmarkMixture`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver tries its best to fetch a routing table. It will try all possible
routers while skipping routers on most errors. However, there are a few errors
that are caused by the client. Those errors should be surfaced to the user for
a better UX/DX and should fail fast: there is no reason to try another router
if we expect it tho return the same error.
Those errors are:
Neo.ClientError.Database.DatabaseNotFoundNeo.ClientError.Security.*Neo.ClientError.Security.AuthorizationExpiredNeo.ClientError.Transaction.InvalidBookmarkNeo.ClientError.Transaction.InvalidBookmarkMixtureThis PR also changes auth errors to be properly hydrated when received as HELLO response