-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Warnings overhaul #789
Merged
robsdedude
merged 10 commits into
neo4j:4.4
from
robsdedude:fix-false-deprecation-warning-4.4
Sep 5, 2022
Merged
[4.4] Warnings overhaul #789
robsdedude
merged 10 commits into
neo4j:4.4
from
robsdedude:fix-false-deprecation-warning-4.4
Sep 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix falsely emitted `DeprecationWarning` regarding `update_routing_table_timeout`. * Treat warnings as errors during testing * Changed tests to expect and catch warning or to avoid them.
Merged
robsdedude
force-pushed
the
fix-false-deprecation-warning-4.4
branch
3 times, most recently
from
September 1, 2022 11:34
23731ca
to
86b70cc
Compare
robsdedude
force-pushed
the
fix-false-deprecation-warning-4.4
branch
from
September 1, 2022 11:35
86b70cc
to
e2d79e5
Compare
bigmontz
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gjmwoods
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarning
regardingupdate_routing_table_timeout
.