Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration diagnostic.refreshAfterSave #2731

Closed
chemzqm opened this issue Dec 18, 2020 · 0 comments
Closed

Remove configuration diagnostic.refreshAfterSave #2731

chemzqm opened this issue Dec 18, 2020 · 0 comments
Milestone
v0.0.80

Comments

@chemzqm
Copy link
Member

chemzqm commented Dec 18, 2020

When format buffer on save, it can't work well since the language server needs time to calculate diagnostics.
It also can't work well on buffer create since we don't know the diagnostics is for content on buffer create or current buffer that might be modified by user.
@chemzqm chemzqm added this to the v0.0.80 milestone Dec 18, 2020
chemzqm added a commit that referenced this issue Dec 18, 2020
@chemzqm
fix(diagnostics): refresh for empty collection when displayByAle
bf592f8 
BREAKING CHANGE: remove refreshAfterSave support.

Closes #2726
Closes #2731
@chemzqm chemzqm closed this as completed Dec 18, 2020
andys8 added a commit to andys8/dotfiles that referenced this issue Dec 24, 2020
@andys8
CoC: refreshAfterSave was removed
9c5a417 
<neoclide/coc.nvim#2731>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.80
Development

No branches or pull requests
1 participant
@chemzqm