-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support of ultisnips snippet #3682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3682 +/- ##
==========================================
+ Coverage 78.44% 79.00% +0.56%
==========================================
Files 210 211 +1
Lines 20912 21402 +490
Branches 4724 4848 +124
==========================================
+ Hits 16404 16909 +505
+ Misses 2776 2755 -21
- Partials 1732 1738 +6
Continue to review full report at Codecov.
|
Including: - RELATIVE_FILEPATH - RANDOM - RANDOM_HEX - UUID - BLOCK_COMMENT_START - BLOCK_COMMENT_END - LINE_COMMENT - WORKSPACE_NAME - WORKSPACE_FOLDER
The parent python block possible resolved to wrong value.
Not replace current placeholder
Avoid slice line from end, which could be changed by cursors or snippets.
Content before could be changed which cancel the completion
@chemzqm hi. I'm a little confused, do I need coc-snippets to have ultisnip snippet support or this builtin support is sufficient? Maybe wikipage on snippets now needs an update? https://github.com/neoclide/coc.nvim/wiki/Using-snippets |
It only add support for parse ultisnips snippets, not provide them, https://github.com/neoclide/coc.nvim/pull/3682/files#diff-4f45caa500ef03d94d3c2bfa556caa1642df95d4e2b980d76b876a8fd2e8c522 coc-snippets needs upgrade to make use of it. |
The goal is better support for ultinips python features, including:
snip.c
:Other changes:
g:coc_snippet_prev
on first placeholder<Cmd>
for key mapping to avoid mode change.New VSCode snippet variables: