fix(typings): getDocument return type. #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fannheyward
approved these changes
Aug 31, 2024
|
Do we need to keep this undefined result or modify unit test to migrate to null? |
|
Many unit tests assert that getDocument() return value is undefined. https://github.com/neoclide/coc.nvim/actions/runs/10643037745/job/29506143934#step:9:59 |
|
To prevent incompatibility, I think we should also declare both null and undefined. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5132 +/- ##
==========================================
- Coverage 98.39% 98.39% -0.01%
==========================================
Files 273 273
Lines 26131 26131
Branches 5400 5400
==========================================
- Hits 25712 25711 -1
- Misses 258 259 +1
Partials 161 161 ☔ View full report in Codecov by Sentry. |
fannheyward
approved these changes
Aug 31, 2024
fannheyward
added a commit
that referenced
this pull request
Sep 2, 2024
9c25f2f fix(typings): getDocument return type. (#5132) d4ff928 feat(language-client): modify log time format (#5130) 53e21a9 fix(snippet): deviation in snippet select in the first column (#5104) 0e6a8c7 feat(codeLens): add codeLens.display (#5129) 704295e fix(handler): correct current winid (#5128) aabfc23 fix: ignore failed config file reads (#5118) 56ea360 feat: expose more properties quick list (#5114) 37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122) 80e9f1b chore(package): upgrade micromatch (#5127) 98fa66a chore(packages): lock ESLint versions for now (#5108) bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102) 38697bc chore(handle): typo toggle inlayHint (#5105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.