-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add granular feature: syllables count applied to text #61
Conversation
…pdating the acceptance tests for the syllables count feature
f7aaf15
to
f9a614a
Compare
f9a614a
to
4696665
Compare
…, which fixes the failing 'slow' test - test_apply_text_profiling.py, amended grammar issues from 21 (language_tool_python: 2.3.1) to 22 (newer version of language_tool_python: 2.5.3)
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 490 498 +8
Branches 73 74 +1
=========================================
+ Hits 490 498 +8
Continue to review full report at Codecov.
|
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.31%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
To be able to merge a pull request, there are a few checks:
Checklist
Please check the options that you have completed and strike-out the options that do not apply via this pull request:
the notebooks are updated (see- to be moved to release section of reponotebooks
folder, read the Notebooks docs)CHANGELOG.md
has been updated (please follow the existing format)Goal or purpose of the PR
Added new feature(s) to the granular features groups:
Changes implemented in the PR
language_tool_python
from2.3.1
to2.5.3
, which fixes a failing test