ci: use reusable workflow for MacOs build #9392
Draft
+71
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedordikarev
added
the
run-extra-build-macos
bayandin
reviewed
Oct 15, 2024
Comment on lines
+28
to
+39
| - name: Check for Postgres changes | ||
| uses: dorny/paths-filter@1441771bbfdd59dcd748680ee64ebd8faab1a242 #v3 | ||
| id: postgres_changes | ||
| with: | ||
| token: ${{ github.token }} | ||
| filters: | | ||
| postgres-v14: ['vendor/postgres-v14/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v15: ['vendor/postgres-v15/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v16: ['vendor/postgres-v16/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| postgres-v17: ['vendor/postgres-v17/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
| base: ${{ github.event_name != 'pull_request' && (github.event.merge_group.base_ref || github.ref_name) || '' }} | ||
| ref: ${{ github.event_name != 'pull_request' && (github.event.merge_group.head_ref || github.ref) || ''}} |
There was a problem hiding this comment.
I was thinking about having this part in the main build_and_test workflow and trigger build-macos only if there're related changes.
We might want to consider using https://github.com/tj-actions/changed-files (instead of dorny/paths-filter), I found its API nicer
| postgres_changes: ${{ steps.postgres_changes.outputs.changes }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6 # v4.1.7 |
There was a problem hiding this comment.
We're ok to use the latest tag (like @v4) for "official" actions from actions org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging