TASK: Deprecate Flow's RequestInterface #3295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not to be confused with the psr requests interface. TLTR: Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request. _Initially_ the interface was introduced with neos@2a26925 at beginning of time. At that time this was done probably to be able to type against the interface instead of the abstract `Request` class, that the Cli and Web Request both extended. With the removal of many methods in its interface neos@8c40ff2 and with the full separation of action and cli requests neos#1552 the interface became useless. The dispatcher and controller interface are both typed against the `ActionRequest` and so it's impossible to implement a custom request.
This was referenced Jan 30, 2024
Merged
|
Will be part of #3301, where we go one step further to remove the interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be confused with the psr requests interface.
TLTR:
Since the separation of http and cli requests the interface is completely unused. And strict types against its only implementation, the ActionRequest make it impossible to implement a custom request.
Initially the interface was introduced with 2a26925 at beginning of time. At that time this was done probably to be able to type against the interface instead of the common
Requestclass, that the Cli and Web Request both extended.With the removal of many methods in its interface 8c40ff2 and with the full separation of action and cli requests #1552 the interface became useless.
The dispatcher and controller interface are both typed against the
ActionRequestand so it's impossible to implement a custom request.Upgrade instructions
Please reference the
ActionRequestinstead in typehints.Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions