BUGFIX: Adjust to PHP 8.3 get_parent_class() deprecation #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsunet
approved these changes
Oct 30, 2024
|
Thank you! :) Good catch |
|
Please do not merge this. For reasons still unknown to me, this leads to the following exception when querying repositories that extend other repositories: Call to a member function createQueryForType() on null
Type: Error
File: Packages/Framework/Neos.Flow/Classes/Persistence/Repository.php
Line: 137So somehow this leads to the |
6 tasks
|
See further comments in #3351 |
|
hmmm thanks for your pr ... but that error would be odd to be caused by this change? I myself am using php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, https://github.com/neos/flow-development-collection/pull/3351/files only targeted Flow 9.0, but per the docs, Flow 8.3 also supports PHP 8.3.
This is just a backport of these changes.