Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Always add space between IP and severity in file logs #3408

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mtelgkamp
Copy link

For all IP addresses of length 15 or longer (most ipv6 addresses) no space was added between the IP address and the Severity.

This bugfix always adds a space character between IP and severity.

Review instructions

Check if IPv6 addresses are separated with a space in log files.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution. Small but very useful. Great that you found it.

Support for 7.3 is security only and as this is probably not a security risk it would have to move up to 8.3. We can take care of that though.

For all IP addresses of length 15 or longer (most ipv6 addresses) no space was added between the IP address and the Severity.

This bugfix always adds a space character between IP and severity.
@mtelgkamp mtelgkamp changed the base branch from 7.3 to 8.3 October 29, 2024 12:00
@github-actions github-actions bot added 8.3 and removed 7.3 labels Oct 29, 2024
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@dlubitz dlubitz merged commit 6476c4d into neos:8.3 Oct 29, 2024
3 checks passed
@dlubitz
Copy link
Contributor

dlubitz commented Oct 29, 2024

https://github.com/neos/flow-development-collection/actions/runs/11573510085

Now the tests are failing :/ Wondering why the tests didn't run on the PR. I'll fix the test.

@mtelgkamp mtelgkamp deleted the bugfix-log-ip-separation branch October 29, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants