-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CleanupNeos 9.0 composer.json #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO won't work, this mostly needs to be fixed in https://github.com/neos/neos-development-distribution/blob/9.0/Build/set-dependencies.sh
AND you need to take the stability flag into account as for non stable releases we want/should/need to require the respective dev/beta versions specifically here. So e.g. neos/media etc should stay. I think set-dependencies needs to be adapted to set the dependency on the dbaladapter.
Fair enough but i that should not be necessary as |
It works due to our/my own quickhack / fix here: 39f7d21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like the idea I mentioned in the comment before, so no block anymore, as then this change would be good. That change to set-depdenncies needs to happen before next beta though, otherwise we will just get all these dependencies back in here.
Fixes: neos/neos-development-collection#5215