Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanupNeos 9.0 composer.json #62

Merged
merged 1 commit into from
Aug 29, 2024
Merged

CleanupNeos 9.0 composer.json #62

merged 1 commit into from
Aug 29, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign changed the title Fix Neos 9.0 composer.json CleanupNeos 9.0 composer.json Aug 27, 2024
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO won't work, this mostly needs to be fixed in https://github.com/neos/neos-development-distribution/blob/9.0/Build/set-dependencies.sh
AND you need to take the stability flag into account as for non stable releases we want/should/need to require the respective dev/beta versions specifically here. So e.g. neos/media etc should stay. I think set-dependencies needs to be adapted to set the dependency on the dbaladapter.

@mhsdesign
Copy link
Member Author

AND you need to take the stability flag into account as for non stable releases we want/should/need to require the respective dev/beta versions specifically here. So e.g. neos/media etc should stay.

Fair enough but i that should not be necessary as neos/fusion-afx neos/timeable-node-visibility neos/contentrepository-core etc are not required manually here as well but are installed never the less due to the dependency set in neos/neos. @nezaniel and me figured that it would just be useless and wrong to manually require neos/fusion here ...

@kitsunet
Copy link
Member

It works due to our/my own quickhack / fix here: 39f7d21
With minimum-stability. But I would probably not want to leave it at that once we have a stable version (TBD), true though we could decide for either or. Actually that would maybe be the right choice? We throw all these dependencies out here, and the set-dependencies script in "STABILITY_FLAG" mode instead just sets the minimum-stability/prefer-stable things, because that should be enough 🤔

Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like the idea I mentioned in the comment before, so no block anymore, as then this change would be good. That change to set-depdenncies needs to happen before next beta though, otherwise we will just get all these dependencies back in here.

@nezaniel nezaniel merged commit d0199ec into 9.0 Aug 29, 2024
@nezaniel nezaniel deleted the mhsdesign-patch-1 branch August 29, 2024 08:25
@mhsdesign
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants