-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! Make Value Objects stricter #4133
Labels
Milestone
Comments
skurfuerst
changed the title
Make Value Objects stricter
!!! Make Value Objects stricter
Mar 31, 2023
bwaidelich
added a commit
that referenced
this issue
Apr 1, 2023
github-project-automation
bot
moved this from Under Review 👀
to Done ✅
in Neos 9.0 Release Board
Apr 14, 2023
Reopening, because #4156 only addresses the |
We decided that:
|
I think #4241 solves most things, but I am not sure if this is completely fixed already. @bwaidelich can look over this when he's back :) |
IMO this is done \o/ |
github-project-automation
bot
moved this from In Progress 🚧
to Done ✅
in Neos 9.0 Release Board
Sep 19, 2023
6 tasks
neos-bot
pushed a commit
to neos/neos
that referenced
this issue
Oct 25, 2023
…to `toDebugString` Related neos/neos-development-collection#4133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use a lot of
Value Objects
in the code for 9.0 but most of them lack validation.IMO we should introduce some validation before a first release because that's impossible to do in a backwards--compatible manner lateron (it will always be possible to relax the rules without breaking changes).
We should also get rid of the magic
__toString()
methods from Value Objects in order to prevent accidental type conversion.Example:
could become sth like
The text was updated successfully, but these errors were encountered: