BUGFIX: Display flash messages in Fusion based backend modules #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sebobo since i know you ran into this issue already. Do you think this is a viable solution. |
mficzel
force-pushed
the
bugfix/displayFlashMessagesInFusionBasedBackendModules
branch
from
e298164
to
8699c4d
Compare
Previously flash messages were not displayed in fusion based backend modules because the rendering was implemented in the BackendSubModule. This layout which was used by all BackendSubModules which had to use the same or a cloned layout. This change moves the rendering to the template of the backend module controller. This makes sense because first this is not a layout task at all and second it makes sense to always render flash messages in the backend. Resolves. neos#3998
mficzel
force-pushed
the
bugfix/displayFlashMessagesInFusionBasedBackendModules
branch
from
8699c4d
to
4507194
Compare
|
Looks like a smart solution, we should have done years ago 🥳 But how can we prevent duplicate flash messages with all existing modules? |
|
@Sebobo as far as i know the rendering removes flash messages from the pool. So i assume there will ne no duplicate rendering. |
|
I'll test with my modules and get back to you :) |
markusguenther
approved these changes
Jan 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously flash messages were not displayed in fusion based backend modules because the rendering was implemented in the BackendSubModule. This layout which was used by all BackendSubModules which had to use the same or a cloned layout.
This change moves the rendering to the template of the backend module controller which renders around all modules. This makes sense because first this is not a layout task at all and second it makes sense to always render flash messages in the backend.
Resolves. #3998
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions