TASK: Export event cleanup and error handling for catchupd events #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error should be enhanced by its event type and sequence number: ``` Failed to decode data of event "e9d12a09-16ef-41ae-82b7-b2485e69ee95": Control character error, possibly incorrectly encoded ```
mhsdesign
force-pushed
the
task/cleanupThingsRegardingEvents
branch
from
151c609
to
59fdeef
Compare
mhsdesign
commented
Mar 18, 2024
| * @param array<mixed> $payload | ||
| * @param array<mixed> $metadata | ||
| */ | ||
| public function __construct( | ||
| public readonly string $identifier, | ||
| public readonly string $type, | ||
| public readonly array $payload, // TODO: string | ||
| public readonly array $payload, |
There was a problem hiding this comment.
fyi i tried to solve the todo #4917 but its senseless ^^
6 tasks
bwaidelich
previously requested changes
Mar 18, 2024
mhsdesign
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fixed the root source for the frequent problem of workspace rebase failed events having a too big payload #4545, which might be clamped when dumping the events table and importing it elsewhere where it cannot be decoded.
But i think enriching the error with the sequence number makes sense, as the event id might not really be known to developers.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions