BUGFIX Workspace aware NodeCacheEntryIdentifier

[dlubitz]

No description provided.

[mhsdesign]

Im currently digging into the history of this NodeCacheEntryIdentifier what is it and since when? Its def new with. 9.0

[bwaidelich]

Nice. Such a simple change.
I would be much more confident if we had a test for this, preferably a behat test. But I'm not sure how that would look like?!

[mhsdesign]

originally the Neos 8.3 node was a CacheAwareInterface:

neos-development-collection/Neos.ContentRepository/Classes/Domain/Model/Node.php

Line 1806 in eada1db

public function getCacheEntryIdentifier(): string

With this pr 8336726 the method was removed from the Neos 9-dev Node (in preparation for standalone).

A few days later Neos.Caching.entryIdentifierForNode was introduced 62555a1

And code was rewritten to use this new helper

  @cache {
     mode = 'cached'
     entryIdentifier {
-       documentNode = ${node}
+       documentNode = ${Neos.Caching.entryIdentifierForNode(node)}

[mhsdesign]

While on it i would also like to move it to Neos\Neos\Fusion\Cache as well? :D (but could do so as well :D)

[mhsdesign]

I know this pr is kindof exploding with comments relative to the lines changed but imo thats a good part. For example until now i was not really aware of this breaking change from 8.3 and so with this in mind we could possibly back-port Neos.Caching.entryIdentifierForNode to make live easier ;)

Also to better fit the fusion pattern: being rather short we could also consider using Neos.Caching.entryIdentifier(node) or implement magic so people wont have to use this helper at all? Or implement a flowquery.

Imo fusion is the part were we should put much dedication into as well, that means knowing all breaking changes and designing a well suited api. (The original change was obscured in a 148 additions and 71 deletions change set which would not even make it to auto generated release notes)

[mhsdesign]

On the other hand Neos.Caching.entryIdentifierForNode vs Neos.Caching.entryIdentifier doesnt make that big of a difference and would cause just extra work right now.

I think we can keep it and i took the time to create a list of things like this, which have to be migrated manually and possibly backported to 8.3

neos/rector#67