Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Convert *DateTime XML elements to \DateTimeImmutable during import #5249

Open
wants to merge 1 commit into
base: 8.4
Choose a base branch
from
Open

BUGFIX: Convert *DateTime XML elements to \DateTimeImmutable during import #5249

wants to merge 1 commit into from

Conversation

grebaldi
Copy link
Contributor

fixes: #5248

Steps To Reproduce

Run ./flow site:import on a site export (presumably one that has been done with Neos 8.3 or earlier) in a Neos 8.4 setup. Make sure doctrine/dbal@3.* is installed. You should see an error like this:

Exception #1300360480 in line 99 of [...]/Framework/Neos.Flow/Classes/ObjectManagement/DependencyInjection/DependencyProxy.php: Error: During import an exception occurred: "Could not convert PHP value of type DateTime to type date_immutable. Expected one of the following types: null, DateTimeImmutable".

After checking out this branch, the error should be gone.

@grebaldi grebaldi linked an issue Sep 16, 2024 that may be closed by this pull request
BUG: "Could not convert PHP value of type DateTime to type date_immutable" during ./flow site:import #5248
Open
1 task
mhsdesign
mhsdesign approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
8.4 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: "Could not convert PHP value of type DateTime to type date_immutable" during ./flow site:import
2 participants
@grebaldi @mhsdesign