BUGFIX: 5265 - Ignore null values in SearchTermMatcher #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve error message by adding context
kdambekalns
approved these changes
Sep 26, 2024
mhsdesign
reviewed
Sep 26, 2024
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| return match (true) { | ||
| $value === null => false, |
There was a problem hiding this comment.
i dont actually understand why its null? The SerializedPropertyValue ensures that its never null?
But maybe its the stupid $subValue iteration of mine? Good catch. I was trying to be clever and fully accurate ^^
There was a problem hiding this comment.
yep, it's definitively not the property value itself, it's a value within the property value, which is a complex VO collection in my case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5265
This will skip null values (evaluating them as not matching) in nested property structures.
Also improves the resulting error message by adding context.
Upgrade instructions
None
Review instructions
None
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions