BUGFIX: Add primitive Root ErrorBoundary around whole UI #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
requested changes
May 10, 2023
|
Added the fancy buttons ^^ with @jonnitto (thanks!) |
|
Love that! ❤️ |
|
todo:
|
TASK: Fix layout and add copy button thanks to @jonnitto TASK: Move buttons together TASK: Add sparkles to ReloadNeosUiButton TASK: Remove dep `react-error-boundary` TASK: More descriptive error in dev context ;) TASK: Style issues
mhsdesign
force-pushed
the
bugfix/primitiveRootErrorBoundary
branch
from
6b80543
to
0f34897
Compare
mhsdesign
changed the title
mhsdesign
changed the title
|
I would prefer not to have the "fancy" Logo. In slack it is ok, but I would not use it on an official document |
|
Okay no problemo ^^ |
jonnitto
reviewed
Jun 19, 2023
jonnitto
reviewed
Jun 19, 2023
Co-authored-by: Jon Uhlmann <[email protected]>
|
@Sebobo ping ^^ |
crydotsnake
approved these changes
Jun 19, 2023
6 tasks
|
Will add the translations via weblate ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, im currently developing on 8.3 but will cherry-pick this to 7.3 once ready... (webpack and me are never going back together)
The idea is that in case of fatal errors, a fallback error boundary is set at root level, so that less technical people dont report: "my neos just turned white" but can give directly informations about the problems. Users can also easily differentiate problems and if one error keeps turning up.
What I did
How I did it
How to verify it
ever