Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Neos redirection issue in subfolder configuration #3713

Merged
merged 5 commits into from
Feb 11, 2024

Conversation

markusguenther
Copy link
Member

Addressing an issue where the redirection to /neos fails when Neos runs in a subfolder. This commit introduces a new route to the defaultModule. The index action of the backend controller is responsible for ensuring the correct backend module. Additionally, consideration for the preferredStartModules configuration has been incorporated here.

Fixes: neos/neos-development-collection#4797

Addressing an issue where the redirection to /neos fails when Neos runs in a subfolder. This commit introduces a new route to the defaultModule. The index action of the backend controller is responsible for ensuring the correct backend module. Additionally, consideration for the preferredStartModules configuration has been incorporated here.

Fixes: neos/neos-development-collection#4797
@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.0 labels Feb 6, 2024
@markusguenther
Copy link
Member Author

If this is ok, we can maybe also use it here in the neos-ui manifest

// This is an extreme case when even the top node does not exist in the given dimension
                // TODO: still find a nicer way to break out of this situation
                if (!redirectContextPath) {
                    window.location = '/neos';
                    break;
                }

@neos-bot
Copy link

neos-bot commented Feb 6, 2024

🎥 End-to-End Test Recordings

These videos demonstrate the end-to-end tests for the changes in this pull request.

Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in project with subfolder configuration. Works like a charm. Thx for taking care 💖

@ahaeslich
Copy link
Member

We will have to make sure this is not lost during upmerges as of the changes in #3682.

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and using this in the other /neos spot also makes absolutely sense.

@markusguenther
Copy link
Member Author

Hmm, now the end-to-end tests are not working anymore 🙈

@mhsdesign
Copy link
Member

sorry :D

@markusguenther markusguenther merged commit 53548fe into neos:8.0 Feb 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.0 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants