BUGFIX: Remove duplicated apply button in DateInput & handle onChange on date selection #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
changed the title
grebaldi
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Nice one 👍
I was able to verify that this change works as expected. The good ol' apply button of the DateTimeEditor has been a pain for many, so thanks a lot for finally removing it @Alvadda!
EDIT: Follow-up for Neos.Neos, because the translation label for the button will be obsolete once this is merged: neos/neos-development-collection#4928
markusguenther
approved these changes
Mar 12, 2024
|
This needs to target |
added 2 commits
March 14, 2024 12:02
… on date selection directly BUGFIX: Remove duplicated apply button in DateInput & handle onChange on date selection directly
Alvadda
force-pushed
the
bugfix/removeDuplicateApplyButtonsOnDateTimePicker
branch
from
7bfae8a
to
5d7b12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current date picker required a separate click to a blue "apply" button to actually set the field value. Afterwards the editors still had to click the inspector apply which leads to confusion. This is especially problematic in the CreationDialog where the apply button often is below the visible area which causes additional confusion.
This change improved DateTime Editor UX by auto-applying date/time selections which allowed to remove the DatePicker's "Apply" button entirely. The DateTime Editor still closes once the editor clicks outside.
For testings: Define a DateTime property and verify that you can set the date value without second apply.
Fixes: #3421