TASK: Backport the end to end tests from 8.4 #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8.4: fix e2e tests # Conflicts: # packages/neos-ui-redux-store/src/CR/Nodes/selectors.ts
TASK: Use saucectl with configuration
|
As I got the feedback that we have too many shell scripts for the tasks, I would try to unify the scripts somehow. |
To be able to reuse parts the change extracts tasks into functions.
mhsdesign
approved these changes
Sep 26, 2024
… positioning When the inspector tab panel is scrolled just enough, so that there\'s enough space, SelectBox contents jump below the SelectBox. Would fail otherwise because "document" would be before "tests"
✖ Select Boxes - SelectBox opens above in creation dialog if there's not enough space below.
1) Unable to resize the window because the specified size exceeds the screen size. On macOS, a window cannot be larger than the screen.
Browser: Chrome 129.0.0.0 / Ventura 13
21 | .gt(await ReactSelector('NodeCreationDialog SelectBox').getBoundingClientRectProperty('top'));
22 |});
23 |
24 |test('SelectBox opens above in creation dialog if there\'s not enough space below.', async t => {
25 | await t
> 26 | .resizeWindow(1200, 768)
> WRN Suite errored. error="job start failed (404): Misconfigured -- Resolution you specified is not available for this OS/browser/version/device combo: OS: 'Mac 13', Browser: 'googlechrome', Version: '129.0.6668.59', Device: 'unspecified', Screen Resolution: '1920x1080'; available resolutions: '1024x768', '1152x864', '1280x960', '1376x1032', '1440x900', '1600x1200', '1920x1440', '2048x1536'"
mhsdesign
force-pushed
the
backport-e2e-tests
branch
from
6e60dd5
to
99e989f
Compare
The retrys just fail: Sauce TestCafe Runner 3.9.0 2Running TestCafe 3.6.2 8Error: Cannot find module '/Volumes/Sauce/node/20.14.0/node-v20.14.0-darwin-x64/bin/node_modules/npm/bin/npm-cli.js' 25 26Error: Cannot find module '/Volumes/Sauce/node/20.14.0/node-v20.14.0-darwin-x64/bin/node_modules/npm/bin/npm-cli.js' 56ERROR No tests match your filter. 57See https://testcafe.io/documentation/402638/reference/configuration-file#filter. 58 59Type "testcafe -h" for help. 60JUnit file generation skipped: no test suites detected.
|
With testcafe 3 we can use native cdp automation for chromium. So to ensure that our tests also work on chromium based browsers locally we should add chrome to the test matrix. Thats why i change the test to run on chrome on mac os. Additionally i added exit code handling to the bash script to signal if a test failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3850
Related: #3851
In the 8.4 branch, we worked on improving the acceptance test setup. Since we are supporting both Neos 8.3 and 8.4 simultaneously, the new test setup includes updated versions of TestCafe and SauceLabs.
This PR just backports the functionality.
The e2e.sh got some new parameters to be able to run local tests and saucelabs. Additionally, we introduce a help parameter to get more details on the usage.
e2e.sh --helpFor the saucelabs usage we need the environment variables
SAUCE_USERNAMEandSAUCE_ACCESS_KEYe2e.sh --saucelabsLocal usage with e.g. the chrome browser works like that
e2e.sh --browser chrome