-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Prevent augmenter from applying data of multiple nodes into the same element #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Sep 25, 2024
…he same element This fixes a regression introduced in #b56135a01ecf59ae3a4990e3fd54ac766732e0e6 which removed the script tag, causing the augmenter to add the data of multiple nodes into the same html element in certain cases instead of adding an outer div. With this change this behaviour is now more explicit instead of relying on the inner workings of the augmenter.
Sebobo
force-pushed
the
bugfix/enforce-dom-node-for-augmentation
branch
from
September 25, 2024 10:49
cbf46ef
to
0b964bd
Compare
mhsdesign
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks seems like the most clean and correct solution for this case.
I cannot upmerge this fix to Neos 9 as the class was moved to Neos.Neos so this change has to be redone there! |
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Oct 8, 2024
…he same element 9.0 port of neos/neos-ui#3856 Original Commit MSG: This fixes a regression introduced in #b56135a01ecf59ae3a4990e3fd54ac766732e0e6 which removed the script tag, causing the augmenter to add the data of multiple nodes into the same html element in certain cases instead of adding an outer div. With this change this behaviour is now more explicit instead of relying on the inner workings of the augmenter.
6 tasks
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Oct 9, 2024
…he same element 9.0 port of neos/neos-ui#3856 Original Commit MSG: This fixes a regression introduced in #b56135a01ecf59ae3a4990e3fd54ac766732e0e6 which removed the script tag, causing the augmenter to add the data of multiple nodes into the same html element in certain cases instead of adding an outer div. With this change this behaviour is now more explicit instead of relying on the inner workings of the augmenter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This fixes a regression introduced in b56135a which removed the script tag, causing the augmenter to add the data of multiple nodes into the same html element in certain cases instead of adding an outer div. This lead to an error with the FlowQuery JavaScript API as it couldn't handle two nodepaths separated by a space as a single nodepath.
With this change the augmenter automatically adds an outer div if a node attribute appears twice. Therefore we have a single element for each wrapped node.
How to verify it
Create the following nodetype in the demo package:
NodeType:
Fusion prototype:
In 8.3.10 the rendered node in the backend would have two values in its context-path and fusion-path attributes and the FlowQuery endpoint throws an error when loading.
With the change the backend works fine again as in 8.3.9 and parent and child node are selectable.