TASK: Adjust to "serializable commands" #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Nov 9, 2024
| $command instanceof ChangeNodeAggregateType => | ||
| $dimensionSpacePoint = match ($event::class) { | ||
| NodeAggregateWasMoved::class => | ||
| $event->succeedingSiblingsForCoverage->toDimensionSpacePointSet()->getFirst(), |
There was a problem hiding this comment.
todo this is maybe cheesy? We look into the succeedingSiblingsForCoverage ???
There was a problem hiding this comment.
Nasty.. I created an issue for that neos/neos-development-collection#5360
mhsdesign
reviewed
Nov 9, 2024
| NodeAggregateWithNodeWasCreated::class => | ||
| $event->originDimensionSpacePoint->toDimensionSpacePoint(), | ||
| NodeReferencesWereSet::class => | ||
| $event->affectedSourceOriginDimensionSpacePoints->toDimensionSpacePointSet()->getFirst(), |
There was a problem hiding this comment.
not ideal that there is only a set here and not a originDimensionSpacePoint like in SetSerializedNodeProperties?
Regression from 36a5de7 as the deduplication did not work.
mhsdesign
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: neos/neos-development-collection#5353
Related: neos/neos-development-collection#5348