Replace cairo-language-server with scarb-cairo-language-server and update installation docs
#3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glepnir
reviewed
Sep 23, 2024
Comment on lines
3
to
4
| local bin_name = 'scarb-cairo-language-server' | ||
| local cmd = { bin_name, '/C', '--node-ipc' } |
There was a problem hiding this comment.
these can be both removed just inline cmd into return cmd field.
There was a problem hiding this comment.
Alright. Will do
funkycadet
force-pushed
the
cairo_ls
branch
from
4ad6afb
to
8861dc9
Compare
|
thanks. |
|
its all good 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Cairo Language Server (
cairo_ls) configuration inlspconfigto usescarb-cairo-language-serverinstead ofcairo-language-server. This change aligns with the new standard as Scarb is now the default package manager for Cairo, and the Scarb-distributed language server extension ensures compatibility with the version of the Cairo compiler used in Scarb.cairo-language-serverwithscarb-cairo-language-server, reflecting Scarb as the default package manager.This change simplifies user configuration and ensures they are working with the correct versions of the Cairo compiler and language server.