feat(julials): add JuliaActivateEnv to activate a julia environment
#3318
Conversation
|
Looks like this fails the CI/CD check regarding the use of |
| @@ -1,5 +1,34 @@ | |||
| local util = require 'lspconfig.util' | |||
|
|
|||
| local function activate_env() | |||
| local bufnr = vim.api.nvim_get_current_buf() | |||
| local julials_client = util.get_active_client_by_name(bufnr, 'julials') | |||
There was a problem hiding this comment.
use vim.lsp.get_clients(). This util.get_active_client_by_name function should be removed @glepnir (at least in all of our configs, and deprecated if we're worried about breaking consumers).
There was a problem hiding this comment.
In order to facilitate the transition of 0.9 users, which version will completely stop supporting 0.9x? 0.10.2 or 0.11. then i can clean up utils including using vim.fs.
There was a problem hiding this comment.
Updated in latest commit revision
There was a problem hiding this comment.
which version will completely stop supporting 0.9x?
We can drop 0.9 support now, if we want. But that's separate from the first step, which is to all usages of vim.util (where possible) in the configs in this repo :)
There was a problem hiding this comment.
It might be a good idea to keep the 0.9 support for now simply because the debian packages are currently at 0.9 so it would be good to have such a core plugin support the versions that are widely available. Moving forward it could be a good idea to make some sort of development practice such as "will support the latest 2 Neovim stable releases at all time or something just so people have an idea what is valid and enable a bit more stability in configuration management, but this is a separate discussion
There was a problem hiding this comment.
It might be a good idea to keep the 0.9 support
Irrelevant for this PR. vim.lsp.get_clients() exists in 0.9
There was a problem hiding this comment.
Irrelevant for this PR.
vim.lsp.get_clients()exists in 0.9
I figured adding code that doesn't not match the current Neovim version support of the plugin would be irrelevant for this PR and a followup would make the blanket decision of which Neovim version to support. For now, I have removed the 0.9 support as requested
There was a problem hiding this comment.
If the idea is to remove all usages of util in the configuration. For now, should I include 0.9 support by checking for the old, deprecated function name?
There was a problem hiding this comment.
For now it seems like this PR shouldn't change the required neovim version since that is out of scope of what I am doing here. I have removed all reliance of the lspconfig util and also support neovim 0.8+ since that is listed in the README requirements
mehalter
force-pushed
the
julia_env
branch
4 times, most recently
from
5966b7f
to
6a87db5
Compare
This adds a command for the additional
julialsAPI for activating an environment. This is based on how extra functionality is added into thetexlabconfiguration