Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2 Release Notes language corrections. #169

Merged

Conversation

mpgreaves
Copy link
Contributor

No description provided.

Copy link
Contributor

nephio-prow bot commented Sep 12, 2024

Hi @mpgreaves. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 2e6328c
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66f511217db5590008c64891
😎 Deploy Preview https://deploy-preview-169--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CsatariGergely
Copy link
Contributor

/assign @liamfallon @ciaranjohnston

@CsatariGergely
Copy link
Contributor

The broken link is fixed in #170

@liamfallon
Copy link
Member

/ok-to-test

@liamfallon
Copy link
Member

This PR needs a rebase to pull in the fix for the broken link in #170

@CsatariGergely
Copy link
Contributor

@liamfallon merge was done

@liamfallon
Copy link
Member

/lgtm
/approve

@nephio-prow nephio-prow bot added the lgtm label Sep 26, 2024
Copy link
Contributor

nephio-prow bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Sep 26, 2024
@nephio-prow nephio-prow bot merged commit bc652c9 into nephio-project:main Sep 26, 2024
8 checks passed
CsatariGergely pushed a commit to nokia/nephio-docs that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants