Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic proofreading #172

Merged
merged 19 commits into from
Oct 1, 2024
Merged

Conversation

CsatariGergely
Copy link
Contributor

This pr adds a GitHub action what runs Vale on the documentation. At the moment it just produces suggestions what we should consider as options.
On the long run we should bend both the Vale checking rules and our documentation to have no findings.

Now it gives me a several hundred item long list of issues. I will start working myself through the list.

Now without a token

Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 69ca291
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66f510978cf46f0008de4fd9
😎 Deploy Preview https://deploy-preview-172--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CsatariGergely
Copy link
Contributor Author

/assign @ciaranjohnston @efiacor

Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
@liamfallon
Copy link
Member

/approve

@nephio-prow nephio-prow bot added the approved label Sep 26, 2024
@liamfallon
Copy link
Member

@radoslawc Are you happy to bring this in?

@radoslawc
Copy link
Contributor

@liamfallon yes, that should do it

@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkq, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@radoslawc radoslawc merged commit a1a088a into nephio-project:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants