Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose kpt package rendering errors via the status of PackageVariant #75

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

kispaljr
Copy link
Collaborator

@kispaljr kispaljr commented Jun 20, 2024

Fixes nephio-project/nephio#730

This implementation exposes the render status of downstream package revisions in the downstreamTargets field of PackageVariant's status.

@nephio-prow nephio-prow bot requested review from henderiw and s3wong June 20, 2024 00:06
@kispaljr
Copy link
Collaborator Author

The reason behind exposing the RenderStatus as a Conditions is that it doesn't require to modify the CRD/schema days before Release date.

If CRD modifications are allowed, then I would consider adding a renderStatus field to items of status.downstreamTargets as a more elegant solution.

@kispaljr
Copy link
Collaborator Author

I rewrote the PR to expose render status via status.downstreamTargets. As I commented above I consider this a superior solution, even though it requires a minor change in the PC schema.

@kispaljr
Copy link
Collaborator Author

/retest

@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot removed the lgtm label Jun 24, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 24, 2024
Copy link
Contributor

nephio-prow bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kispaljr, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit 2e851ad into nephio-project:main Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packagevariant does not fail when function rendering does not happen for target package
2 participants