-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose kpt package rendering errors via the status of PackageVariant #75
Conversation
The reason behind exposing the RenderStatus as a Conditions is that it doesn't require to modify the CRD/schema days before Release date. If CRD modifications are allowed, then I would consider adding a renderStatus field to items of status.downstreamTargets as a more elegant solution. |
I rewrote the PR to expose render status via |
9ca5511
to
aa7c673
Compare
/retest |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes nephio-project/nephio#730
This implementation exposes the render status of downstream package revisions in the
downstreamTargets
field of PackageVariant's status.